Enact follow-up phase of the "Path to Saner Increment/Decrement operators" RFC#19374
Merged
Girgias merged 2 commits intophp:masterfrom Aug 23, 2025
Merged
Enact follow-up phase of the "Path to Saner Increment/Decrement operators" RFC#19374Girgias merged 2 commits intophp:masterfrom
Girgias merged 2 commits intophp:masterfrom
Conversation
Girgias
force-pushed
the
inc-dec-phase-2
branch
from
926d4ab to
67c98b1
Compare
17 tasks
arnaud-lb
approved these changes
Aug 22, 2025
Comment on lines
+2568
to
+2569
| zval_ptr_dtor(str); | ||
| ZVAL_STR(str, zstr); |
Member
There was a problem hiding this comment.
Suggest to re-add the comment /* A userland error handler can change the type from string to something else */ here to remind why we are doing this
edorian
approved these changes
Aug 23, 2025
Member
edorian
left a comment
edorian
left a comment
There was a problem hiding this comment.
RM approval. No technical review performed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#enact_follow-up_phase_of_the_path_to_saner_incrementdecrement_operators_rfc